syntax: Always pretty print a newline after doc comments #31746
Conversation
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
|
Travis is unhappy: https://travis-ci.org/rust-lang/rust/builds/110040268 |
|
I was afraid of that. This bug only shows up when the doc comment is the very first line. Any comments or even whitespace doesn't trip the problem. Does anyone know how to get tidy to ignore this file? |
|
Yeah there's some way of whitelisting files but I can't remember exactly how. |
|
Actually probably just |
Before this patch, code that had a doc comment as the first line, as in: ```rust /// Foo struct Foo; ``` Was pretty printed into: ```rust ///Foostruct Foo; ``` This makes sure that that there is always a trailing newline after a doc comment. Closes rust-lang#31722
|
@sfackler: Updated! |
|
@bors r+ |
|
📌 Commit 0e3334e has been approved by |
|
⌛ Testing commit 0e3334e with merge 362fb6b... |
|
@bors: retry force clean |
|
⌛ Testing commit 0e3334e with merge 255a3e6... |
|
💔 Test failed - auto-win-gnu-64-nopt-t |
|
@bors: retry On Wed, Mar 16, 2016 at 2:14 PM, bors notifications@github.com wrote:
|
syntax: Always pretty print a newline after doc comments Before this patch, code that had a doc comment as the first line, as in: ```rust /// Foo struct Foo; ``` Was pretty printed into: ```rust ///Foostruct Foo; ``` This makes sure that that there is always a trailing newline after a doc comment. Closes #31722
Before this patch, code that had a doc comment as the first
line, as in:
Was pretty printed into:
///Foostruct Foo;This makes sure that that there is always a trailing newline
after a doc comment.
Closes #31722