Skip to content

Fix tests that used // | help: annotations #30773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2016
Merged

Conversation

fhahn
Copy link
Contributor

@fhahn fhahn commented Jan 7, 2016

In my PR for #21659 I accidentally used // | help as test annotation. This PR updates it to //~| help. I also found and updated 2 other tests with the same issue.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Hm out of curiosity, these are actually tested, right? I vaguely remember that at some point in the past these may not have been checked (specifically help, not other errors).

@fhahn
Copy link
Contributor Author

fhahn commented Jan 14, 2016

Yep, they are checked.

@alexcrichton
Copy link
Member

@bors: r+ 6ce9ac4

Ok cool, thanks!

@bors
Copy link
Collaborator

bors commented Jan 15, 2016

⌛ Testing commit 6ce9ac4 with merge b035da4...

@bors
Copy link
Collaborator

bors commented Jan 15, 2016

💔 Test failed - auto-linux-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Jan 14, 2016 at 8:47 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-opt
http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/7667


Reply to this email directly or view it on GitHub
#30773 (comment).

@bors
Copy link
Collaborator

bors commented Jan 15, 2016

⌛ Testing commit 6ce9ac4 with merge fe04d14...

bors added a commit that referenced this pull request Jan 15, 2016
In my PR for #21659 I accidentally used `// | help` as test annotation. This PR updates it to `//~| help`. I also found and updated 2 other tests with the same issue.
@bors
Copy link
Collaborator

bors commented Jan 15, 2016

💔 Test failed - auto-linux-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Jan 15, 2016 at 2:04 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/7653


Reply to this email directly or view it on GitHub
#30773 (comment).

@bors
Copy link
Collaborator

bors commented Jan 15, 2016

⌛ Testing commit 6ce9ac4 with merge dd51c3a...

bors added a commit that referenced this pull request Jan 15, 2016
In my PR for #21659 I accidentally used `// | help` as test annotation. This PR updates it to `//~| help`. I also found and updated 2 other tests with the same issue.
@bors bors merged commit 6ce9ac4 into rust-lang:master Jan 15, 2016
@fhahn fhahn deleted the test-fix branch January 15, 2016 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants