Skip to content

Add long error diagnostics for E0401 #29916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2015
Merged

Conversation

Manishearth
Copy link
Member

No description provided.

@Manishearth
Copy link
Member Author

r? @steveklabnik


This may require additional type hints in the function body.

In case the function is in an `impl`, defining a private helper function might
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impl block maybe ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really a block

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you call it ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just call it an impl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear people say both.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 20, 2015

📌 Commit c23cbae has been approved by steveklabnik

bors added a commit that referenced this pull request Nov 21, 2015
@bors
Copy link
Collaborator

bors commented Nov 21, 2015

⌛ Testing commit c23cbae with merge 79b7a9e...

@bors bors merged commit c23cbae into rust-lang:master Nov 21, 2015
@Manishearth Manishearth deleted the diag-401 branch December 2, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants