-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Store a valid name for the root module in metadata #29788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Thanks! Could you also add a test for this? |
I added a test, though I didn't yet have time to actually run it through |
(test fixed) |
@bors r+ rollup 528d086 |
📌 Commit 528d086 has been approved by |
⌛ Testing commit 528d086 with merge 04942ca... |
💔 Test failed - auto-linux-musl-64-opt |
// aux-build:issue-28927-2.rs
// aux-build:issue-28927-1.rs
+// ignore-cross-compile
extern crate issue_28927_1 as inner1;
pub use inner1 as foo; |
(fixed test and squashed) |
@bors: retry force |
⚡ Previous build results for auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-64-opt, auto-win-msvc-32-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-64-opt... |
@mitaa, thanks! |
f357d55 caused a regression by retrieving item names from metadata, while previously using the last element of its absolute path (which in the case of a root module is the prefixed crate name since the stored path in metadata is empty)
fixes #28927