Skip to content

Store a valid name for the root module in metadata #29788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2015

Conversation

mitaa
Copy link
Contributor

@mitaa mitaa commented Nov 11, 2015

f357d55 caused a regression by retrieving item names from metadata, while previously using the last element of its absolute path (which in the case of a root module is the prefixed crate name since the stored path in metadata is empty)

fixes #28927

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Thanks! Could you also add a test for this?

@mitaa
Copy link
Contributor Author

mitaa commented Nov 12, 2015

I added a test, though I didn't yet have time to actually run it through make check...

@mitaa
Copy link
Contributor Author

mitaa commented Nov 12, 2015

(test fixed)

@arielb1
Copy link
Contributor

arielb1 commented Nov 12, 2015

@bors r+ rollup 528d086

@bors
Copy link
Collaborator

bors commented Nov 12, 2015

📌 Commit 528d086 has been approved by arielb1

@bors
Copy link
Collaborator

bors commented Nov 13, 2015

⌛ Testing commit 528d086 with merge 04942ca...

@bors
Copy link
Collaborator

bors commented Nov 13, 2015

💔 Test failed - auto-linux-musl-64-opt

@mitaa
Copy link
Contributor Author

mitaa commented Nov 13, 2015

89b6f39

 // aux-build:issue-28927-2.rs
 // aux-build:issue-28927-1.rs
+// ignore-cross-compile

 extern crate issue_28927_1 as inner1;
 pub use inner1 as foo;

@mitaa
Copy link
Contributor Author

mitaa commented Nov 13, 2015

(fixed test and squashed)

@alexcrichton
Copy link
Member

@bors: r=arielb1 02f9a49

bors added a commit that referenced this pull request Nov 15, 2015
f357d55 caused a regression by retrieving item names from metadata, while previously using the last element of its absolute path (which in the case of a root module is the prefixed crate name since the stored path in metadata is empty)

fixes #28927
@bors
Copy link
Collaborator

bors commented Nov 15, 2015

⌛ Testing commit 02f9a49 with merge 531b053...

@alexcrichton
Copy link
Member

@bors: retry force

@bors bors merged commit 02f9a49 into rust-lang:master Nov 16, 2015
@mitaa mitaa deleted the module_name branch November 16, 2015 08:17
@IvanUkhov
Copy link
Contributor

@mitaa, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc - panicked at 'Unexpected empty destination: ["dsp"]' - occurs on beta and nightly
6 participants