Add examples to methods on integer types #29712
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ 4a31f3ddf9120a5758e22ad714fc688c89be4902 Thanks! |
|
@bors: r- this failed on travis: https://s3.amazonaws.com/archive.travis-ci.org/jobs/90055835/log.txt plus i have some inline comments |
| /// | ||
| /// # Examples | ||
| /// | ||
| /// ```rust |
There was a problem hiding this comment.
we don't use the rust in API documentation, can these be removed?
|
@steveklabnik I've addressed the inline comments :-) |
| @@ -140,6 +140,7 @@ macro_rules! int_impl { | |||
| /// Leading and trailing whitespace represent an error. | |||
| /// | |||
| /// # Examples | |||
| /// Basic usage: | |||
There was a problem hiding this comment.
Oh, sorry, can you put a space between this and the # Examples? This is cramped, I know it still works markdown-wise
|
After travis passes and that one last nit, r=me (Sorry for being so nit-picky, consistent style is hard) |
|
@steveklabnik No problem at all; looks like Travis has passed |
|
@bors: r+ rollup |
|
📌 Commit 5e68056 has been approved by |
|
🎊 thanks so much again |
Adds `Example` sections to the rest of the integer methods. cc @steveklabnik
ghost
deleted the
Adds
Examplesections to the rest of the integer methods.cc @steveklabnik