Goyox86/rustfmting librustc driver II #29650
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
|
||
| Ok((outputs, trans)) | ||
| }) | ||
| { |
There was a problem hiding this comment.
Woah. I guess I see why it indented this so far -- but often times you want a trailing closure to only be 4 space indented. Is there a known issue on this?
There was a problem hiding this comment.
Rustfmt indents the closure at a "visual" level because it's not the last item in the chain. If we'd indent this at a "block" level, the following .collect() would be out of place.
There was a problem hiding this comment.
Seems like maybe the issue where large closures should be block indented rather than visual? I couldn't find the issue for it, but I know there is one!
goyox86
force-pushed
the
goyox86/rustfmting-librustc_driverII
branch
from
52730af to
82f1391
Compare
|
☔ The latest upstream changes (presumably #29674) made this pull request unmergeable. Please resolve the merge conflicts. |
|
seems ok, r=me, once rebased, presuming that a bug has been filed about the string constant and comment paragraphization |
|
As of a few minutes ago, rustfmt should no longer split comments |
|
@nikomatsakis I don't see a comment about a string constant? |
|
@nrc there was a mis-formatted string constant, which I believe was fixed by hand in this commit goyox86@82f1391 |
|
I think that is https://github.com/nrc/rustfmt/issues/397 |
goyox86
force-pushed
the
goyox86/rustfmting-librustc_driverII
branch
from
82f1391 to
4f050bf
Compare
|
@bors r+ thanks! |
|
📌 Commit 4f050bf has been approved by |
Hi Rustaceans!
This is the secong take on running latest rustfmt on librustc_driver!
All fixups made in #29033 were done (also rustfmt got better).
//cc @nrc