Fix ICE with unresolved associated items in closures (fixes #28971) #29515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this is the right approach. Copying over my comment from the issue: Either we need to abort_if_errors when creating the closure EUV in typeck/check/upvar.rs, in analyze_closure(), OR we need to abort in check_path_enum in _match.rs. abort_if_errors means that it may not finish checking the whole crate, so the errors will get cut off. We need to determine where it's acceptable to cut it off. Is there a smarter way to handle this? Perhaps by propagating a TyError or something? |
Manishearth
force-pushed
the
ice-itembody
branch
from
e31b5aa to
55932c5
Compare
| // Error handling done inside resolve_ty_and_def_ufcs | ||
| // Later parts of typeck need everything to be fully resolved, | ||
| // if it isn't, we should bail | ||
| tcx.sess.abort_if_errors(); |
There was a problem hiding this comment.
I don't like this. Can't we do better?
Manishearth
force-pushed
the
ice-itembody
branch
from
55932c5 to
6468292
Compare
|
@bors r+ |
|
📌 Commit 6468292 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @eddyb or @nrc