Skip to content

Implement IntoIterator for &{Path, PathBuf} #29514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Implement IntoIterator for &{Path, PathBuf} #29514

merged 1 commit into from
Nov 3, 2015

Conversation

apasel422
Copy link
Contributor

Closes #26220.

r? @alexcrichton

@bluss
Copy link
Member

bluss commented Nov 2, 2015

if PathBuf should have a consuming iterator it's best to add it now (to not break .into_iter() later). I guess it's probably not going to have it?

@apasel422
Copy link
Contributor Author

I'll look into adding it shortly.

On Monday, November 2, 2015, bluss notifications@github.com wrote:

if PathBuf should have a consuming iterator it's best to add it now (to
not break .into_iter() later). I guess it's probably not going to have it?


Reply to this email directly or view it on GitHub
#29514 (comment).

@apasel422
Copy link
Contributor Author

@bluss Now that I'm looking into how this is implemented, I'm not sure what a consuming iterator for PathBuf would be.

@bluss
Copy link
Member

bluss commented Nov 2, 2015

Right, it doesn't seem to make sense. Sorry, just a knee-jerk check due to recent discussions where .into_iter() means .iter() for certain types.

@alexcrichton
Copy link
Member

@bors: r+ 6ad6cc3

Thanks!

bors added a commit that referenced this pull request Nov 3, 2015
@bors
Copy link
Collaborator

bors commented Nov 3, 2015

⌛ Testing commit 6ad6cc3 with merge 3330f54...

@bors bors merged commit 6ad6cc3 into rust-lang:master Nov 3, 2015
@apasel422 apasel422 deleted the issue-26220 branch November 3, 2015 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants