Fix build of libc on stable #29216
Merged
Fix build of libc on stable #29216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,7 @@ | |||
| html_playground_url = "https://play.rust-lang.org/", | |||
| issue_tracker_base_url = "https://github.com/rust-lang/rust/issues/")] | |||
| #![cfg_attr(test, feature(test))] | |||
| #![feature(cfg_target_vendor)] | |||
| #![cfg_attr(cfg_target_vendor, feature(cfg_target_vendor))] | |||
There was a problem hiding this comment.
I think this should be not(feature = "cargo-build") instead of cfg_target_vendor, right? (e.g. similar to the above feature annotation)
There was a problem hiding this comment.
Ah! I was looking at line 26 for inspiration, not 15.
steveklabnik
force-pushed
the
fix_libc
branch
from
3f2b06d to
c9d6d09
Compare
|
@alexcrichton updated! I also moved them next to each other, since they're related. |
|
Hm did this go awry? There's no longer a |
steveklabnik
force-pushed
the
fix_libc
branch
2 times, most recently
from
fc5dc13 to
dd8ae4f
Compare
This is needed to release a new version of libc
bors
added a commit
that referenced
this pull request
Oct 23, 2015
This is needed to release a new version of libc r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to release a new version of libc
r? @alexcrichton