cache evaluation results #29209
Merged
cache evaluation results #29209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎆 |
|
@arielb1 sorry, been at a conference, will get to this soon |
Yes, I know. This is the main reason I didn't rip it out a while back. |
|
I will deal with the fat errors on a later PR (this one is getting somewhat too big). |
arielb1
force-pushed
the
exponential-evaluation
branch
from
43d3221 to
7f7b663
Compare
|
OK, I'm feeling pretty good about this patch. r+ from me with that comment. Nice work! |
added 8 commits
November 15, 2015 19:22
arielb1
force-pushed
the
exponential-evaluation
branch
from
7f7b663 to
5982594
Compare
|
@bors r=nmatsakis |
|
📌 Commit 5982594 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 15, 2015
This fixes an exponential worst-case and also provides an additional 1% perf improvement. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an exponential worst-case and also provides an additional 1% perf improvement.
r? @nikomatsakis