Fix some typos #29138
Fix some typos #29138
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -279,7 +279,7 @@ fn extension(file_name: &str) -> Option<&str> { | |||
| } | |||
| ``` | |||
|
|
|||
| One other pattern that we find is very common is assigning a default value to | |||
There was a problem hiding this comment.
Alternatively, the sentence could be restructured slightly to avoid the repeated "is":
One other pattern we commonly find is assigning a default value...
There was a problem hiding this comment.
Thank you @Manishearth.
I understand.
I think that the sentence @caipre suggested is easier to read.
How do you think about that?
|
@Manishearth: rollup please? |
|
@bors r+ rollup |
|
📌 Commit 5a15144 has been approved by |
|
FWIW "rollup" isn't the term to use, you probably meant "review please?" "rollup" is something we use to mark small PRs for being rolled up into mega-PRs if the queue gets backed up. (Not a big deal though) |
|
@Manishearth: Thank you. |
No description provided.