Skip to content

Add docs for ast_ty_to_prim_ty #29074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2015
Merged

Conversation

Manishearth
Copy link
Member

Confusion about what this does caused a bug in Servo's lints.

r? @eddyb

@@ -60,6 +60,8 @@ pub fn prim_ty_to_ty<'tcx>(tcx: &ty::ctxt<'tcx>,
}
}

/// If a type in the AST is a primitive type, return the ty::Ty corresponding
/// to it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually have a period at the end of the summary doc line.

Confusion about what this does caused a bug in Servo's lints.
@eddyb
Copy link
Member

eddyb commented Oct 16, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 16, 2015

📌 Commit e184c2d has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Oct 16, 2015

⌛ Testing commit e184c2d with merge e77a804...

@bors
Copy link
Collaborator

bors commented Oct 16, 2015

💔 Test failed - auto-linux-32-nopt-t

@Manishearth
Copy link
Member Author

@bors retry

@Manishearth
Copy link
Member Author

@bors rollup

@bors
Copy link
Collaborator

bors commented Oct 16, 2015

⌛ Testing commit e184c2d with merge 87e26ef...

bors added a commit that referenced this pull request Oct 16, 2015
Confusion about what this does caused a bug in Servo's lints.

r? @eddyb
@bors bors merged commit e184c2d into rust-lang:master Oct 16, 2015
@Manishearth Manishearth deleted the astconv-doc branch December 2, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants