-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add docs for ast_ty_to_prim_ty
#29074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -60,6 +60,8 @@ pub fn prim_ty_to_ty<'tcx>(tcx: &ty::ctxt<'tcx>, | |||
} | |||
} | |||
|
|||
/// If a type in the AST is a primitive type, return the ty::Ty corresponding | |||
/// to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually have a period at the end of the summary doc line.
Confusion about what this does caused a bug in Servo's lints.
145a46e
to
e184c2d
Compare
@bors r+ |
📌 Commit e184c2d has been approved by |
⌛ Testing commit e184c2d with merge e77a804... |
💔 Test failed - auto-linux-32-nopt-t |
@bors retry |
@bors rollup |
bors
added a commit
that referenced
this pull request
Oct 16, 2015
Confusion about what this does caused a bug in Servo's lints. r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confusion about what this does caused a bug in Servo's lints.
r? @eddyb