Skip to content

Remove incorrect test for #22872 #28438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2015
Merged

Remove incorrect test for #22872 #28438

merged 1 commit into from
Sep 17, 2015

Conversation

apasel422
Copy link
Contributor

The original issue was not fixed, but the test passed due to disabled debug assertions.

The original issue was not fixed, but the test passed due to disabled
debug assertions.
@rust-highfive
Copy link
Contributor

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Hm, why delete the test though? Seems like it's fine to leave in and if we add a builder for debug assertions it'd require fixing this?

@apasel422
Copy link
Contributor Author

I'm not sure what the final test will look like (i.e. if the errors will
have to change), and it currently causes make check to fail when debug
assertions are enabled locally.

On Wed, Sep 16, 2015 at 1:01 PM, Alex Crichton notifications@github.com
wrote:

Hm, why delete the test though? Seems like it's fine to leave in and if we
add a builder for debug assertions it'd require fixing this?


Reply to this email directly or view it on GitHub
#28438 (comment).

@alexcrichton
Copy link
Member

@bors: r+ f5b69b3

hm ok, seems fine

bors added a commit that referenced this pull request Sep 17, 2015
The original issue was not fixed, but the test passed due to disabled debug assertions.
@bors
Copy link
Collaborator

bors commented Sep 17, 2015

⌛ Testing commit f5b69b3 with merge 6c18dd5...

@bors bors merged commit f5b69b3 into rust-lang:master Sep 17, 2015
@apasel422 apasel422 deleted the issue-22872 branch September 17, 2015 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants