Add a remark about the implicit implementation of Send and make a test for it #28314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -92,6 +92,7 @@ impl Default for AtomicBool { | |||
| } | |||
| } | |||
|
|
|||
| // Send is implicitely implemented for AtomicBool. | |||
There was a problem hiding this comment.
s/implicitely/implicitly/
(and below)
tbu-
force-pushed
the
pr_atomics_are_send
branch
from
0812209 to
51354e9
Compare
|
@bors r+ rollup |
|
📌 Commit 51354e9 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Sep 15, 2015
|
⌛ Testing commit 51354e9 with merge c437c15... |
|
💔 Test failed - auto-mac-64-opt |
tbu-
force-pushed
the
pr_atomics_are_send
branch
from
51354e9 to
9407cd5
Compare
|
This was a legit failure, I fixed it. |
|
This test already exists: src/test/run-pass/sync-send-atomics.rs |
tbu-
force-pushed
the
pr_atomics_are_send
branch
from
9407cd5 to
1b3745f
Compare
|
@wthrowe Ok, removed the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.