Skip to content

Don't add unnamed address attributes to intrinsics. #28277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2015

Conversation

DiamondLovesYou
Copy link
Contributor

Intrinsics never have an address, so it doesn't make sense to say that their
address is unnamed.

Intrinsics never have an address, so it doesn't make sense to say that their
address is unnamed.
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@huonw
Copy link
Member

huonw commented Sep 7, 2015

@bors r+

Out of interest: does the current behaviour cause problems, or is this just a tidy-up?

@bors
Copy link
Collaborator

bors commented Sep 7, 2015

📌 Commit ba72d97 has been approved by huonw

@DiamondLovesYou
Copy link
Contributor Author

It causes problems on PNaCl because the verifier rejects the extra
attribute. However, it's still unnecessary in the general case.

On Sun, Sep 6, 2015 at 11:00 PM, Huon Wilson notifications@github.com
wrote:

@bors https://github.com/bors r+

Out of interest: does this cause problems, or just a tidy-up?


Reply to this email directly or view it on GitHub
#28277 (comment).

@bors
Copy link
Collaborator

bors commented Sep 7, 2015

⌛ Testing commit ba72d97 with merge e6ab614...

@bors
Copy link
Collaborator

bors commented Sep 7, 2015

💔 Test failed - auto-win-msvc-64-opt

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Collaborator

bors commented Sep 9, 2015

⌛ Testing commit ba72d97 with merge 55da0e0...

bors added a commit that referenced this pull request Sep 9, 2015
Intrinsics never have an address, so it doesn't make sense to say that their
address is unnamed.
@bors bors merged commit ba72d97 into rust-lang:master Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants