Skip to content

document advanced extern crate/use syntax #28250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2015
Merged

Conversation

durka
Copy link
Contributor

@durka durka commented Sep 5, 2015

I took a stab at fixing #28064. Not sure if this all-features-in-one-example approach is the right one. Also I completely made up the terms "star globbing" and "brace expansion globbing" -- they are just called "glob-like syntax" in the reference.

I took a stab at fixing rust-lang#28064. Not sure if this all-features-in-one-example approach is the right one. Also I completely made up the terms "star globbing" and "brace expansion globbing" -- they are just called "glob-like syntax" in the reference.
@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@durka durka changed the title document advance extern crate/use syntax document advanced extern crate/use syntax Sep 5, 2015
```rust,ignore
extern crate phrases as sayings;

use sayings::japanese::greetings as ja_greetings;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps jp_greetings? jp is the usual shorthand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems JP is the country (ISO 3166) and JA is the language (ISO 639).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction :)

@sinistersnare
Copy link
Contributor

Somewhere we need to mention that a crate named foo-bar is automatically assigned the name foo_bar, because crate names must be identifiers.

@durka
Copy link
Contributor Author

durka commented Sep 5, 2015

@sinistersnare added.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 9, 2015

📌 Commit a506b7c has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Sep 9, 2015

⌛ Testing commit a506b7c with merge 3cda3c9...

bors added a commit that referenced this pull request Sep 9, 2015
I took a stab at fixing #28064. Not sure if this all-features-in-one-example approach is the right one. Also I completely made up the terms "star globbing" and "brace expansion globbing" -- they are just called "glob-like syntax" in the reference.
@bors bors merged commit a506b7c into rust-lang:master Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants