typeck: handle unsized structs in type hints by recursing into their last field. #27294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @nrc |
|
@bors: r+ |
|
📌 Commit 2c69514 has been approved by |
eddyb
force-pushed
the
deep-unsize-hinting
branch
from
2c69514 to
c46f913
Compare
|
@bors r=nrc |
|
📌 Commit c46f913 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 26, 2015
`Rc::new(RefCell::new(x)): Rc<RefCell<Trait>>` should not mean `RefCell::new(x): RefCell<Trait>`. The latter is impossible, as an rvalue can't have an unsized type. We were already handling unsized argument hints, but not when dealing with unsized structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rc::new(RefCell::new(x)): Rc<RefCell<Trait>>should not meanRefCell::new(x): RefCell<Trait>.The latter is impossible, as an rvalue can't have an unsized type.
We were already handling unsized argument hints, but not when dealing with unsized structures.