-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add more std::io documentation. #26903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
/// While usual Rust style is to import types directly, aliases of `Result` often are not, to make | ||
/// it easier to distinguish between them. `Result` is generally assumed to be | ||
/// `std::result::Result`, and so users of this alias will generally use `io::Result` instead of | ||
/// shadowing the prelud's import of `std::result::Result`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prelude
2193053
to
e3e6d87
Compare
@alexcrichton updated! |
/// is otherwise a direct mapping to `std::result::Result`. | ||
/// [result]: ../result/enum.Result.html | ||
/// | ||
/// This type is broadly used across `std::io` for any operation which may produce an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same 80-char concern here as I had below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, i specifically tried to watch out for this for you :(
e3e6d87
to
16639c9
Compare
@alexcrichton updated again :) |
@@ -1 +1 @@ | |||
Subproject commit 8e4f8ea581502a2edc8177a040300e05ff7f91e3 | |||
Subproject commit 0da191a30ba385215c5eb1dc97c2b5f076f93b07 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accidental update?
Looks good to me, thanks @steveklabnik! r=me |
16639c9
to
1239e34
Compare
This round: io::Result and the free functions.
@bors: r=alexcricthon rollup |
📌 Commit 1239e34 has been approved by |
…excricthon This round: io::Result and the free functions.
This round: io::Result and the free functions.
This round: io::Result and the free functions.