Skip to content

Add more std::io documentation. #26903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2015
Merged

Conversation

steveklabnik
Copy link
Member

This round: io::Result and the free functions.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

/// While usual Rust style is to import types directly, aliases of `Result` often are not, to make
/// it easier to distinguish between them. `Result` is generally assumed to be
/// `std::result::Result`, and so users of this alias will generally use `io::Result` instead of
/// shadowing the prelud's import of `std::result::Result`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prelude

@steveklabnik steveklabnik force-pushed the io_function_docs branch 2 times, most recently from 2193053 to e3e6d87 Compare July 9, 2015 16:27
@steveklabnik
Copy link
Member Author

@alexcrichton updated!

/// is otherwise a direct mapping to `std::result::Result`.
/// [result]: ../result/enum.Result.html
///
/// This type is broadly used across `std::io` for any operation which may produce an error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same 80-char concern here as I had below)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, i specifically tried to watch out for this for you :(

@steveklabnik
Copy link
Member Author

@alexcrichton updated again :)

@@ -1 +1 @@
Subproject commit 8e4f8ea581502a2edc8177a040300e05ff7f91e3
Subproject commit 0da191a30ba385215c5eb1dc97c2b5f076f93b07
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental update?

@alexcrichton
Copy link
Member

Looks good to me, thanks @steveklabnik!

r=me

This round: io::Result and the free functions.
@steveklabnik
Copy link
Member Author

@bors: r=alexcricthon rollup

@bors
Copy link
Collaborator

bors commented Jul 10, 2015

📌 Commit 1239e34 has been approved by alexcricthon

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 10, 2015
…excricthon

This round: io::Result and the free functions.
bors added a commit that referenced this pull request Jul 11, 2015
This round: io::Result and the free functions.
@bors
Copy link
Collaborator

bors commented Jul 11, 2015

⌛ Testing commit 1239e34 with merge f7f28c8...

@bors bors merged commit 1239e34 into rust-lang:master Jul 11, 2015
@steveklabnik steveklabnik deleted the io_function_docs branch June 19, 2016 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants