Refactor how the parser looks for sub-modules #26750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the functionality usable from outside the parser
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
nrc
referenced
this pull request
in cassiersg/rustfmt
Jul 3, 2015
| /// Information about the path to a module. | ||
| pub struct ModulePath { | ||
| pub name: String, | ||
| pub path_exists: bool, |
There was a problem hiding this comment.
This probably makes more sense inside of ModulePathError, right?
There was a problem hiding this comment.
It's needed in both cases. In the non-error case, there can still be an error if !self.owns_directory and then we need to check path_exists. That can't be checked without a parser, so we need to be pass out path_exists here.
|
@sfackler review ping |
|
@bors r+ sorry |
|
📌 Commit f3ba950 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 13, 2015
This makes the functionality usable from outside the parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the functionality usable from outside the parser