Prohibit casts between fat pointers to different traits #26394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes them compliant with the new version of RFC 401 (i.e.
RFC 1052).
Fixes rust-lang#26391. I *hope* the tests I have are enough.
This is a [breaking-change]
|
ping @rust-lang/lang because of the breaking change |
|
Also cc @brson to see if we can test this on crater |
| @@ -99,6 +99,12 @@ fn main() | |||
| let l_via_str = unsafe{&*(s as *const [u8])}; | |||
| assert_eq!(&l, l_via_str); | |||
|
|
|||
| // ptr-ptr-cast (both vk=Length, check length is preserved) | |||
|
r+ for the code (modulo nit). We should discuss the breaking change aspect before landing this though |
|
addressed. I think the breaking change was part of the RFC (this is a 1.2 -> 1.2 breaking change, the code ICE-d before). |
|
Crater is started on this. |
|
Since this is only a breaking change within a version, I think it is OK to land. If Crater finds anything horrible some how, we can back out. @bors: r+ |
|
📌 Commit 5133606 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes them compliant with the new version of RFC 401 (i.e.
RFC 1052).
Fixes #26391. I hope the tests I have are enough.
This is a [breaking-change]
r? @nrc