deprecate BitSet and BitVec #26034
deprecate BitSet and BitVec #26034
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @rust-lang/libs r? @aturon |
|
.. it appears to not have. throws up hands in disgust |
|
👍 |
|
Oh yeah, I meant to write up the motivation for this. I guess I woke up this morning and was just like "well obviously everyone knows why we should do this". BitVec and BitSet are marked unstable still because they have several outstanding design problems:
None of these are a real problem in a crate where we can expose janky interfaces and rename whimsically. While I agree that a collection of bits is a very useful datastructure, I'd argue the standard collections library should be small, focusing on The Big Dogs of datastructuring. Vec, HashMap, SortedMap, RingBuf, LinkedList. |
|
I'm all for this!
You'll need to put the |
| @@ -81,12 +81,11 @@ | |||
| return; | |||
| } | |||
|
|
|||
| if (e.which === 191) { // question mark | |||
|
Is this ready to go now that the stability lint has been fixed? Probably worth testing a fresh/rebased build to make sure it's working properly. |
Gankra
force-pushed
the
deprecate-bits
branch
2 times, most recently
from
0b43e2a to
5d8a756
Compare
|
updated |
|
cc @jroesch for where we still use these |
|
@gankro the only remaining place is the one we talked about on IRC earlier for attributes. I think if we just move a copy of the implementation into |
|
@jroesch I also found it in librustc_lint. I missed it before as the compile error'd out on the first one and stopped. |
|
@bors r=alexcrichton |
|
📌 Commit 7850c8d has been approved by |
I've mirrored them out to crates (bit-vec and bit-set) that build on stable. (not sure if this actually correctly deprecates them in std)
I've mirrored them out to crates (bit-vec and bit-set) that build on stable.
(not sure if this actually correctly deprecates them in std)