Skip to content

configure: Fix LLVM output dir on MSVC #26004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2015

Conversation

alexcrichton
Copy link
Member

If LLVM assertions are enabled for MSVC, it looks like the output directory is
still just Release (or assertions are just always ignored on MSVC).

If LLVM assertions are enabled for MSVC, it looks like the output directory is
still just `Release` (or assertions are just always ignored on MSVC).
@alexcrichton
Copy link
Member Author

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned nikomatsakis Jun 4, 2015
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Jun 4, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 4, 2015

📌 Commit 3d74fbd has been approved by brson

@bors
Copy link
Collaborator

bors commented Jun 5, 2015

⌛ Testing commit 3d74fbd with merge d95df9a...

bors added a commit that referenced this pull request Jun 5, 2015
If LLVM assertions are enabled for MSVC, it looks like the output directory is
still just `Release` (or assertions are just always ignored on MSVC).
@bors bors merged commit 3d74fbd into rust-lang:master Jun 5, 2015
@alexcrichton alexcrichton deleted the msvc-llvm-assertions branch July 10, 2015 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants