Skip to content

tuple.rs: Document more traits that Tuple implements if its components do #24826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joshtriplett
Copy link
Member

Tuples implement Debug, Hash, and Rand if their components do.

…nts do

Tuples implement Debug, Hash, and Rand if their components do.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

//! * `Default`
//! * `Hash`
//! * `Rand`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently just an internal trait, so can this be left out?

@steveklabnik
Copy link
Member

@joshtriplett ping! Can you make the change @alexcrichton suggested?

bors added a commit that referenced this pull request Jun 24, 2015
Tuples implement Debug and Hash if their components do.

closes #24826

r? @alexcrichton 

cc @steveklabnik
@bors bors closed this in #26520 Jun 24, 2015
@bors
Copy link
Collaborator

bors commented Jun 24, 2015

☔ The latest upstream changes (presumably #26520) made this pull request unmergeable. Please resolve the merge conflicts.

@joshtriplett joshtriplett deleted the three-tuple-transitive-traits branch July 26, 2017 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants