Skip to content

positive tests are preferable to negative ones #24634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

positive tests are preferable to negative ones #24634

wants to merge 1 commit into from

Conversation

tshepang
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

There's actually a semantic difference between ch.is_lowercase() and !ch.is_uppercase(). For example I believe this code was originally intended to solve #21735 where some characters may not be lowercase but don't have a lowercase equivalent (for example).

@tshepang
Copy link
Member Author

Interesting one. I will add a comment to that effect.

@tshepang tshepang closed this Apr 20, 2015
@tshepang tshepang deleted the make-negative-test-positive branch April 20, 2015 20:51
@tshepang
Copy link
Member Author

Done in #24642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tshepang @rust-highfive @alexcrichton