Skip to content

a couple misc changes #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2012
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/cargo/cargo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,7 @@ import vec;
import std::getopts;
import getopts::{optflag, optopt, opt_present};

enum _src {
/* Break cycles in package <-> source */
_source(source),
}

type package = {
// source: _src,
name: str,
uuid: str,
url: str,
Expand Down Expand Up @@ -293,7 +287,6 @@ fn load_one_source_package(&src: source, p: map::hashmap<str, json::json>) {
};

vec::grow(src.packages, 1u, {
// source: _source(src),
name: name,
uuid: uuid,
url: url,
Expand Down
18 changes: 18 additions & 0 deletions src/libcore/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,24 @@ impl reader_util for reader {
while !self.eof() { buf += self.read_bytes(2048u); }
buf
}

fn each_byte(it: fn(int) -> bool) {
while !self.eof() {
if !it(self.read_byte()) { break; }
}
}

fn each_char(it: fn(char) -> bool) {
while !self.eof() {
if !it(self.read_char()) { break; }
}
}

fn each_line(it: fn(str) -> bool) {
while !self.eof() {
if !it(self.read_line()) { break; }
}
}
}

// Reader implementations
Expand Down
2 changes: 1 addition & 1 deletion src/libstd/sha1.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#[doc ="
An implementation of the SHA-1 cryptographic hash.

First create a `sha1` object using the `mk_sha1` constructor, then
First create a `sha1` object using the `sha1` constructor, then
feed it input using the `input` or `input_str` methods, which may be
called any number of times.

Expand Down
17 changes: 17 additions & 0 deletions src/libstd/time.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export
get_time,
precise_time_ns,
precise_time_s,
tzset,
tm,
empty_tm,
now,
Expand All @@ -20,6 +21,7 @@ native mod rustrt {
fn get_time(&sec: i64, &nsec: i32);
fn precise_time_ns(&ns: u64);

fn rust_tzset();
// FIXME: The i64 values can be passed by-val when #2064 is fixed.
fn rust_gmtime(&&sec: i64, &&nsec: i32, &&result: tm);
fn rust_localtime(&&sec: i64, &&nsec: i32, &&result: tm);
Expand Down Expand Up @@ -59,6 +61,10 @@ fn precise_time_s() -> float {
ret (precise_time_ns() as float) / 1000000000.;
}

fn tzset() {
rustrt::rust_tzset();
}

type tm = {
tm_sec: i32, // seconds after the minute [0-60]
tm_min: i32, // minutes after the hour [0-59]
Expand Down Expand Up @@ -869,6 +875,7 @@ mod tests {
#[test]
fn test_at_utc() {
os::setenv("TZ", "America/Los_Angeles");
tzset();

let time = { sec: 1234567890_i64, nsec: 54321_i32 };
let utc = at_utc(time);
Expand All @@ -890,10 +897,13 @@ mod tests {
#[test]
fn test_at() {
os::setenv("TZ", "America/Los_Angeles");
tzset();

let time = { sec: 1234567890_i64, nsec: 54321_i32 };
let local = at(time);

#error("time_at: %?", local);

assert local.tm_sec == 30_i32;
assert local.tm_min == 31_i32;
assert local.tm_hour == 15_i32;
Expand All @@ -916,6 +926,7 @@ mod tests {
#[test]
fn test_to_timespec() {
os::setenv("TZ", "America/Los_Angeles");
tzset();

let time = { sec: 1234567890_i64, nsec: 54321_i32 };
let utc = at_utc(time);
Expand All @@ -927,6 +938,7 @@ mod tests {
#[test]
fn test_conversions() {
os::setenv("TZ", "America/Los_Angeles");
tzset();

let time = { sec: 1234567890_i64, nsec: 54321_i32 };
let utc = at_utc(time);
Expand All @@ -943,6 +955,7 @@ mod tests {
#[test]
fn test_strptime() {
os::setenv("TZ", "America/Los_Angeles");
tzset();

alt strptime("", "") {
ok(tm) {
Expand Down Expand Up @@ -1088,18 +1101,22 @@ mod tests {
#[test]
fn test_ctime() {
os::setenv("TZ", "America/Los_Angeles");
tzset();

let time = { sec: 1234567890_i64, nsec: 54321_i32 };
let utc = at_utc(time);
let local = at(time);

#error("test_ctime: %? %?", utc.ctime(), local.ctime());

assert utc.ctime() == "Fri Feb 13 23:31:30 2009";
assert local.ctime() == "Fri Feb 13 15:31:30 2009";
}

#[test]
fn test_strftime() {
os::setenv("TZ", "America/Los_Angeles");
tzset();

let time = { sec: 1234567890_i64, nsec: 54321_i32 };
let utc = at_utc(time);
Expand Down
6 changes: 5 additions & 1 deletion src/rt/rust_builtin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,11 @@ struct tm* LOCALTIME(const time_t *clock, tm *result) {
#define TIMEGM(result) timegm(result)
#endif

extern "C" CDECL void
rust_tzset() {
TZSET();
}

extern "C" CDECL void
rust_gmtime(int64_t *sec, int32_t *nsec, rust_tm *timeptr) {
tm tm;
Expand All @@ -541,7 +546,6 @@ rust_gmtime(int64_t *sec, int32_t *nsec, rust_tm *timeptr) {
extern "C" CDECL void
rust_localtime(int64_t *sec, int32_t *nsec, rust_tm *timeptr) {
tm tm;
TZSET();
time_t s = *sec;
LOCALTIME(&s, &tm);

Expand Down
1 change: 1 addition & 0 deletions src/rt/rustrt.def.in
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ debug_abi_2
get_port_id
get_task_id
get_time
rust_tzset
rust_gmtime
rust_localtime
rust_timegm
Expand Down