add forgotten index and fix array type #2335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2022
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
tshepang
pushed a commit
to tshepang/rust
that referenced
this pull request
Apr 19, 2025
Enable `[canonicalize-issue-links]` and `[no-mentions]` in triagebot.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to add index in some situations.
The x86-64 classification algorithm was directly translated from clay's externals.cpp.
Maybe we can translate clay's code into rust to fix x86 ABI problem.