rand: Use wrapping operations everywhere #23105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
rand-wrapping
branch
from
3c718a2 to
5180436
Compare
|
A user hit this in IRC ( |
|
cc @pnkfelix |
|
@bors r+ |
bors
added a commit
that referenced
this pull request
Mar 10, 2015
There was a buildbot failure recently of an arithmetic overflow in the isaac module of the rand crate, so I've imported the isaac implementation from out-of-tree which makes somewhat more liberal usage of the wrapping primitives. Hopefull this quelches any future overflow!
|
💔 Test failed - auto-linux-64-nopt-t |
There was a buildbot failure recently of an arithmetic overflow in the isaac module of the rand crate, so I've imported the isaac implementation from out-of-tree which makes somewhat more liberal usage of the wrapping primitives. Hopefull this quelches any future overflow!
alexcrichton
force-pushed
the
rand-wrapping
branch
from
5180436 to
ee7a72c
Compare
|
🙀 |
bors
added a commit
that referenced
this pull request
Mar 10, 2015
There was a buildbot failure recently of an arithmetic overflow in the isaac module of the rand crate, so I've imported the isaac implementation from out-of-tree which makes somewhat more liberal usage of the wrapping primitives. Hopefull this quelches any future overflow!
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 10, 2015
There was a buildbot failure recently of an arithmetic overflow in the isaac module of the rand crate, so I've imported the isaac implementation from out-of-tree which makes somewhat more liberal usage of the wrapping primitives. Hopefull this quelches any future overflow!
|
⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt are reusable. Rebuilding only auto-win-32-nopt-t... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a buildbot failure recently of an arithmetic overflow in the isaac
module of the rand crate, so I've imported the isaac implementation from
out-of-tree which makes somewhat more liberal usage of the wrapping primitives.
Hopefull this quelches any future overflow!