Skip to content

Fix the std::process::Stdio constructors #22749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2015

Conversation

lilyball
Copy link
Contributor

There are no tests for this because testing inherit/null is tricky.
Probably why there weren't tests for it to begin with.

There are no tests for this because testing inherit/null is tricky.
Probably why there weren't tests for it to begin with.
@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@lilyball
Copy link
Contributor Author

/cc @aturon

@alexcrichton
Copy link
Member

@bors: r+ bbc3f2e

bors added a commit that referenced this pull request Feb 24, 2015
…chton

There are no tests for this because testing inherit/null is tricky.
Probably why there weren't tests for it to begin with.
@bors
Copy link
Collaborator

bors commented Feb 24, 2015

⌛ Testing commit bbc3f2e with merge c9ace05...

@bors
Copy link
Collaborator

bors commented Feb 24, 2015

@bors bors merged commit bbc3f2e into rust-lang:master Feb 24, 2015
@brson
Copy link
Contributor

brson commented Mar 1, 2015

Thanks @kballard!

@lilyball lilyball deleted the process-stdio-constructors branch March 3, 2015 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants