Eliminate assoc type projection predicate candidate duplicates #22185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When projecting associate types for a trait's default methods, the trait itself was added to the predicate candidate list twice: one from parameter environment, the other from trait definition. Then the duplicates were deemed as code ambiguity and the compiler rejected the code. Simply checking and dropping the duplicates solves the issue. Closes rust-lang#22036
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 11, 2015
When projecting associate types for a trait's default methods, the trait itself was added to the predicate candidate list twice: one from parameter environment, the other from trait definition. Then the duplicates were deemed as code ambiguity and the compiler rejected the code. Simply checking and dropping the duplicates solves the issue. Closes rust-lang#22036
|
⌛ Testing commit 2af968e with merge e9f8329... |
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors: retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When projecting associate types for a trait's default methods, the
trait itself was added to the predicate candidate list twice: one from
parameter environment, the other from trait definition. Then the
duplicates were deemed as code ambiguity and the compiler rejected the
code. Simply checking and dropping the duplicates solves the issue.
Closes #22036