Fail nicely when copying artefacts fails #22150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| let output_path = &crate_output.path(output_type); | ||
| if let Err(e) = fs::copy(input_path, output_path) { | ||
| sess.err(&format!("could not copy {:?} to {:?}: {}", | ||
| input_path, output_path, e.description())); |
There was a problem hiding this comment.
I think this may wish to rather just print e itself rather than just the description (as it has more information)
|
@alexcrichton updated |
nagisa
force-pushed
the
de-perm-frost
branch
from
ddf70e3 to
1890395
Compare
| @@ -22,6 +22,7 @@ use syntax::codemap; | |||
| use syntax::diagnostic; | |||
| use syntax::diagnostic::{Emitter, Handler, Level, mk_handler}; | |||
|
|
|||
| use std::error::Error; | |||
There was a problem hiding this comment.
I think that this may be an unused import now.
nagisa
force-pushed
the
de-perm-frost
branch
from
1890395 to
a941fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22124