debuginfo: Better type description of unsized vectors and LLDB test case #21519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -2768,18 +2768,21 @@ fn fixed_vec_metadata<'a, 'tcx>(cx: &CrateContext<'a, 'tcx>, | |||
| let element_llvm_type = type_of::type_of(cx, element_type); | |||
| let (element_type_size, element_type_align) = size_and_align_of(cx, element_llvm_type); | |||
|
|
|||
| let (array_size_in_bytes, upper_bound) = if let Some(len) = len { | |||
There was a problem hiding this comment.
Yes, that would be a better fit here indeed.
michaelwoerister
force-pushed
the
misc
branch
from
08b7f17 to
75ad116
Compare
|
@eddyb Fixed that nit. |
|
@bors r+ 75ad116 |
|
⌛ Testing commit 75ad116 with merge 1435d60... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Jan 25, 2015
Two minor improvements that have been on my TODO list for a while: * Clang uses a size of `-1` for arrays of unknown size and we should do that too as it will tell LLVM to omit the size information in debuginfo. * There was no LLDB test case for handling the optimized enum representation introduced by @luqmana. This PR finally adds one.
|
⌛ Testing commit 75ad116 with merge c80e556... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor improvements that have been on my TODO list for a while:
-1for arrays of unknown size and we should do that too as it will tell LLVM to omit the size information in debuginfo.