Issue 21033 struct var pattern fix #21278
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Thanks! Could you add a few more tests for mixing |
|
Ok, done. I'm not sure if you want the tests in separate files or not but if you do I can separate them. |
| } | ||
| match a { | ||
| E::StructVar { mut boxed } => { } | ||
| } |
There was a problem hiding this comment.
Does this test compile? Isn't a moved into one of the branches above?
|
Ah and all one test is fine by me, just wondering about whether the test compiles today |
|
Bah, not sure how I missed that. Should be fixed now. |
|
@bors: r+ d8372131 |
|
🙀 You have the wrong number! Please try again with |
…x, r=alexcrichton Closes #21033. The new strategy for parsing a field pattern is to look 1 token ahead and if it's a colon, parse as "fieldname: pat", otherwise parse the shorthand form "(box) (ref) (mut) fieldname)". The previous strategy was to parse "(ref) (mut) fieldname" then if we encounter a colon, throw an error if either "ref" or "mut" were encountered.
Closes #21033. The new strategy for parsing a field pattern is to look 1 token ahead and if it's a colon, parse as "fieldname: pat", otherwise parse the shorthand form "(box) (ref) (mut) fieldname)". The previous strategy was to parse "(ref) (mut) fieldname" then if we encounter a colon, throw an error if either "ref" or "mut" were encountered.