Add inline to every String function #20859
Merged
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -138,6 +138,7 @@ impl String { | |||
| /// let output = String::from_utf8_lossy(input); | |||
| /// assert_eq!(output.as_slice(), "Hello \u{FFFD}World"); | |||
| /// ``` | |||
| #[inline] | |||
There was a problem hiding this comment.
I'm not convinced this should be marked inline.
There was a problem hiding this comment.
If there were an attribute #[can_be_inlined] I would have used that. Adding #[inline] is the only way to let llvm decide if it should be inlined.
|
I think I agree with @pnkfelix; the one-line functions seem like no brainers, those that contain non-trivial loops, less clearly so. I think I'm inclined to leave the |
|
Updated |
bors
added a commit
that referenced
this pull request
Jan 10, 2015
bors
added a commit
that referenced
this pull request
Jan 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20822