Require that types cannot implement both Drop and Copy. #20631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nick29581 (rust_highfive has picked a reviewer for you, use r? to override) |
|
@huonw it occurs to me that this check might not quite work for generic structs -- but there is some question as to the correct behavior of Drop in the case of generic structs anyhow (i.e., if you have struct Foo(T), is it ok to impl<T:Bar> Drop for Foo?). Right now it's a moot point because #[unsafe_dtor] is required for generic structs anyway, but eventually that will not be true. (promoting to a comment on the PR so it doesn't go away after rebasing etc) |
|
So I think we want to be careful about generic structs, but that's probably a separate PR. Hence r+. |
bors
added a commit
that referenced
this pull request
Jan 6, 2015
Opt-in built-in traits allowed one to explicitly implement both `Drop` and `Copy` for a type. This can theoretically make some sense, but the current implementation means it is codegened totally incorrectly which can lead to memory unsafety, so this feature is disabled for now. Fixes #20126.
huonw
force-pushed
the
no-drop-and-copy
branch
from
8ba4cfc to
0ea534f
Compare
bors
added a commit
that referenced
this pull request
Jan 7, 2015
Opt-in built-in traits allowed one to explicitly implement both `Drop` and `Copy` for a type. This can theoretically make some sense, but the current implementation means it is codegened totally incorrectly which can lead to memory unsafety, so this feature is disabled for now. Fixes #20126.
Opt-in built-in traits allowed one to explicitly implement both `Drop` and `Copy` for a type. This can theoretically make some sense, but the current implementation means it is codegened totally incorrectly which can lead to memory unsafety, so this feature is disabled for now. Fixes rust-lang#20126.
huonw
force-pushed
the
no-drop-and-copy
branch
from
0ea534f to
3c1ca17
Compare
bors
added a commit
that referenced
this pull request
Jan 8, 2015
Opt-in built-in traits allowed one to explicitly implement both `Drop` and `Copy` for a type. This can theoretically make some sense, but the current implementation means it is codegened totally incorrectly which can lead to memory unsafety, so this feature is disabled for now. Fixes #20126.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opt-in built-in traits allowed one to explicitly implement both
Dropand
Copyfor a type. This can theoretically make some sense, but thecurrent implementation means it is codegened totally incorrectly which
can lead to memory unsafety, so this feature is disabled for now.
Fixes #20126.