Use associated types in binop traits #20390
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binop traits (
Add
,Sub
, etc) now have an associated type for their return type. Also the RHS input parameter defaults toSelf
(except for theShl
andShr
traits). For example, theAdd
trait now looks like this:This breaks all existing implementation of these traits.
[breaking-change]
Needs a snapshot that contains PR #20374
There are some cfail test that are ICEing, I have marked those with a FIXME. We can land this after a snapshot, or wait for fix of those cfail ICEs before landing this.
r? @aturon