Skip to content

Parse arbitrary operators after expr-like macro invocations in statement position #20099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/libsyntax/parse/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2995,14 +2995,17 @@ impl<'a> Parser<'a> {
/// actually, this seems to be the main entry point for
/// parsing an arbitrary expression.
pub fn parse_assign_expr(&mut self) -> P<Expr> {
let lo = self.span.lo;
let lhs = self.parse_binops();
self.parse_assign_expr_with(lhs)
}

pub fn parse_assign_expr_with(&mut self, lhs: P<Expr>) -> P<Expr> {
let restrictions = self.restrictions & RESTRICTION_NO_STRUCT_LITERAL;
match self.token {
token::Eq => {
self.bump();
let rhs = self.parse_expr_res(restrictions);
self.mk_expr(lo, rhs.span.hi, ExprAssign(lhs, rhs))
self.mk_expr(lhs.span.lo, rhs.span.hi, ExprAssign(lhs, rhs))
}
token::BinOpEq(op) => {
self.bump();
Expand All @@ -3020,8 +3023,9 @@ impl<'a> Parser<'a> {
token::Shr => BiShr
};
let rhs_span = rhs.span;
let span = lhs.span;
let assign_op = self.mk_assign_op(aop, lhs, rhs);
self.mk_expr(lo, rhs_span.hi, assign_op)
self.mk_expr(span.lo, rhs_span.hi, assign_op)
}
_ => {
lhs
Expand Down Expand Up @@ -3919,8 +3923,9 @@ impl<'a> Parser<'a> {
let e = self.mk_mac_expr(span.lo,
span.hi,
macro.and_then(|m| m.node));
let e =
self.parse_dot_or_call_expr_with(e);
let e = self.parse_dot_or_call_expr_with(e);
let e = self.parse_more_binops(e, 0);
let e = self.parse_assign_expr_with(e);
self.handle_expression_like_statement(
e,
ast::DUMMY_NODE_ID,
Expand Down
43 changes: 43 additions & 0 deletions src/test/run-pass/parse-complex-macro-invoc-op.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test parsing binary operators after macro invocations.

#![feature(macro_rules)]

macro_rules! id {
($e: expr) => { $e }
}

fn foo() {
id!(1i) + 1;
id![1i] - 1;
id!(1i) * 1;
id![1i] / 1;
id!(1i) % 1;

id!(1i) & 1;
id![1i] | 1;
id!(1i) ^ 1;

let mut x = 1i;
id![x] = 2;
id!(x) += 1;

id!(1f64).clone();

id!([1i, 2, 3])[1];
id![drop](1i);

id!(true) && true;
id![true] || true;
}

fn main() {}