rustdoc: Improve rendering of unboxed closures #19934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks so much @tomjakubowski! |
|
@alexcrichton No problem! I think though that you've r+ed on the commit in the |
|
thanks @steveklabnik! |
|
/me shakes fist sorry :( |
|
@alexcrichton I added another commit to use the |
|
👍 |
tomjakubowski
force-pushed
the
rustdoc-unboxed-closures-redux
branch
from
0fa064f to
a22268c
Compare
|
Rebased and fixed the |
tomjakubowski
force-pushed
the
rustdoc-unboxed-closures-redux
branch
from
a22268c to
809dbf4
Compare
This unfortunately leaves sugaring Fn/FnMut/FnOnce on cross-crate re-exports for future work. cc rust-lang#19909
tomjakubowski
force-pushed
the
rustdoc-unboxed-closures-redux
branch
from
809dbf4 to
64b5464
Compare
|
Rebased, re-r @alexcrichton ? The conflicts were just in deriving for RustcEncodable and RutscDecodable. |
bors
added a commit
that referenced
this pull request
Dec 25, 2014
…dux, r=alexcrichton We render HRTB and the unboxed closure trait sugar (the so-called "parenthesized" notation) where appropriate. Also address the new `for` syntax on the old closures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We render HRTB and the unboxed closure trait sugar (the so-called
"parenthesized" notation) where appropriate. Also address the new
forsyntax on the old closures.