Skip to content

Added example to TempDir #19932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2014
Merged

Added example to TempDir #19932

merged 2 commits into from
Dec 22, 2014

Conversation

elszben
Copy link

@elszben elszben commented Dec 16, 2014

First attempt to contribute to rust (and using github). This commit adds a few examples to std::io::TempDir. The examples seem to look okay (in my browser) and make check also passes.

/// // get the path of the temporary directory without affecting the wrapper
/// let tmppath = tmpdir.path();
///
/// println!("The path of temporary directory is {}", tmppath.as_str().unwrap());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of .as_str().unwrap() the way to print a path is currently .display(), would you be ok switch to that for these examples?

@alexcrichton
Copy link
Member

Thanks for the awesome documentation!

@alexcrichton alexcrichton self-assigned this Dec 17, 2014
@elszben
Copy link
Author

elszben commented Dec 17, 2014

Done. It's awesome that everything is done automatically:) I did not have to do anything beside pushing the changes. Pure awesomeness.

bors added a commit that referenced this pull request Dec 19, 2014
Added example to TempDir

Reviewed-by: alexcrichton
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 21, 2014
First attempt to contribute to rust (and using github). This commit adds a few examples to std::io::TempDir. The examples seem to look okay (in my browser) and make check also passes.
@bors bors merged commit c910252 into rust-lang:master Dec 22, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Jun 9, 2025
fix: Record macro calls in signatures in `ChildBySource` impls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants