syntax: Make asm! clobbers a proper vector.
#19411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise `--pretty expanded` diverges.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. |
| .map(|s| format!("~{{{}}}", s.get())) | ||
| .collect::<Vec<String>>() | ||
| .connect(",") | ||
| .as_slice()); |
There was a problem hiding this comment.
The String::from_str shouldn't be necessary here, right? I thought connect returned a String.
There was a problem hiding this comment.
Sure, I guess it's a leftover from the old code (I didn't notice that :).
|
Thanks @lifthrasiir! Just one small nit and otherwise r=me |
|
@alexcrichton Removed two occurrences (both clobbers and the original code) of allocations. r? |
bors
added a commit
that referenced
this pull request
Nov 30, 2014
…crichton
I.e. we should not prematurely build operand constraints at the expansion time. Otherwise `--pretty expanded` diverges:
```
$ cat t.rs
#![feature(asm)]
pub fn main() { unsafe { asm!("" : : : "hello", "world") }; }
$ rustc t.rs --pretty
#![feature(asm)]
pub fn main() { unsafe { asm!("" : : : "hello" , "world") }; }
$ rustc t.rs --pretty expanded
#![feature(asm)]
#![feature(phase)]
#![no_std]
#![feature(globs)]
#[phase(plugin, link)]
extern crate "std" as std;
#[prelude_import]
use std::prelude::*;
pub fn main() { unsafe { asm!("": : : "~{hello},~{world}") }; }
```
(The last code *does* compile, but won't do the expected thing.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. we should not prematurely build operand constraints at the expansion time. Otherwise
--pretty expandeddiverges:(The last code does compile, but won't do the expected thing.)