Skip to content

std: Close TcpListener with closesocket() #19334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2014

Conversation

alexcrichton
Copy link
Member

This may have inadvertently switched during the runtime overhaul, so this
switches TcpListener back to using sockets instead of file descriptors. This
also renames a bunch of variables called fd to socket to clearly show that
it's not a file descriptor.

Closes #19333

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

This may have inadvertently switched during the runtime overhaul, so this
switches TcpListener back to using sockets instead of file descriptors. This
also renames a bunch of variables called `fd` to `socket` to clearly show that
it's not a file descriptor.

Closes rust-lang#19333
bors added a commit that referenced this pull request Dec 5, 2014
This may have inadvertently switched during the runtime overhaul, so this
switches TcpListener back to using sockets instead of file descriptors. This
also renames a bunch of variables called `fd` to `socket` to clearly show that
it's not a file descriptor.

Closes #19333
@bors bors closed this Dec 5, 2014
@bors bors merged commit d6d4088 into rust-lang:master Dec 5, 2014
@alexcrichton alexcrichton deleted the issue-19333 branch December 28, 2014 06:44
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 28, 2025
internal: Remove generated md book files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"error -1 when closing file descriptor" for TcpListener on win64
3 participants