DSTify Str + impl Str for &S where S: Str #19248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @japaric! It's not clear yet what the ultimate fate of these |
bors
added a commit
that referenced
this pull request
Nov 24, 2014
Just like we do with AsSlice This comes in handy when dealing with iterator-centric APIs (`IntoIterator`!) and you want to receive an `Iterator<S> where S: Str` argument. Without this PR, e.g. you can't receive `&["a", "b"].iter()` instead you'll have to type `&["a", "b"].iter().map(|&x| x)` (A similar thing happens with `&[String]`). r? @aturon Full disclaimer: I haven't run `make`/`make check` yet (All my cores are busy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like we do with AsSlice
This comes in handy when dealing with iterator-centric APIs (
IntoIterator!) and you want to receive anIterator<S> where S: Strargument. Without this PR, e.g. you can't receive&["a", "b"].iter()instead you'll have to type&["a", "b"].iter().map(|&x| x)(A similar thing happens with&[String]).r? @aturon
Full disclaimer: I haven't run
make/make checkyet (All my cores are busy)