Mention that find() doesn't consume the full iterator #19150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
find-doc
branch
from
3f30b9d to
68863e2
Compare
| @@ -549,6 +549,8 @@ pub trait Iterator<A> { | |||
| } | |||
|
|
|||
| /// Return the first element satisfying the specified predicate | |||
| /// | |||
| /// Will not consume the iterator past the first found element | |||
There was a problem hiding this comment.
I think this should be "Returns the... " and "Does not consume..." (also both lines should end with a period).
Content-wise LGTM.
Manishearth
force-pushed
the
find-doc
branch
from
68863e2 to
f85f971
Compare
|
@gankro fixed, thanks |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 22, 2014
It's useful to know this (opens up a bunch of other opportunities especially whilst parsing)
|
@gankro How did this fail? O.o |
|
Runtime/io stuff is really unstable right now. Definitely not your fault (in this PR, at least). |
bors
added a commit
that referenced
this pull request
Nov 23, 2014
It's useful to know this (opens up a bunch of other opportunities especially whilst parsing)
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Feb 17, 2025
Apply cfg.setTest to json projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to know this (opens up a bunch of other opportunities especially whilst parsing)