add a copyless with_str_reader, and remove_file #1914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems ok to me, though |
|
I've pushed the change out. It'll probably need some work once Graydon's os rewrite goes out. |
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Dec 30, 2024
rust-lang#1914) This patch also adds docs for `//@ llvm-cov-flags:`, and notes that coverage tests support revisions (though none of the current tests actually do so).
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
rust-lang#1914) This patch also adds docs for `//@ llvm-cov-flags:`, and notes that coverage tests support revisions (though none of the current tests actually do so).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io::with_str_reader is a copyless way to make a reader from a string. I also renamed string_reader to str_reader, and added a remove_file function. It sounds like Graydon is in the middle of work there, so I'm okay punting on that commit for now.