(core::str) various fixes #1891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of chars; rename find to find_chars; add fixmes to delete byte_index, byte_index_from
…bytes with find[_from]
…byte_index[_from]
|
Argh! I've been working on similar things all morning. I guess I can throw my changes away now. Are you done for today, or is more coming? |
|
Morning? Very sorry 'bout that. Silly time zones... |
|
Done for today, and will be busy on other things for the next few days, too. |
|
Okay, thanks. I'll integrate this and merge in some fixes and optimizations that I made during my own refactor. |
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Deletes the issue template that @celinval added but doesn't show up for some enigmatic reason.
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Dec 30, 2024
* Add some more details on feature gating * Apply suggestions from code review --------- Co-authored-by: Ross Smyth <rsmyth@electrocraft.com> Co-authored-by: Nilstrieb <48135649+Nilstrieb@users.noreply.github.com>
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
* Add some more details on feature gating * Apply suggestions from code review --------- Co-authored-by: Ross Smyth <rsmyth@electrocraft.com> Co-authored-by: Nilstrieb <48135649+Nilstrieb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a lot of the obvious reworking that comes to mind after Issue #1849.
Functions like len, index, rindex, find, and slice now refer to byte indexes. I have not deleted or stopped exporting all of the _chars alternative functions yet, and of course other issues remain.
Anyways, I'm going to be busy with other things for a few days, so it is all yours...