Skip to content

Add example to doc for slice::ImmutableSlice::binary_search. #17819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Oct 6, 2014

Add example to doc for slice::ImmutableSlice::binary_search.

Fix #17817.

@pnkfelix pnkfelix closed this Oct 6, 2014
@pnkfelix
Copy link
Member Author

pnkfelix commented Oct 6, 2014

(there's an obvious improvement I can make to the last assertion in each test ... will reopen after a force push...)

@pnkfelix
Copy link
Member Author

pnkfelix commented Oct 6, 2014

(argh github doesn't let one reopen post a force-push!)

@pnkfelix
Copy link
Member Author

pnkfelix commented Oct 6, 2014

(opened fresh PR in #17820. I guess we're all going to have to open fresh PR's if the reviewers ask us to squash our commits in the future?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: binary_search does not say what order it uses when feeding inputs to callback
1 participant