Display the doc-block toggle on everything again. #17247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs a clone otherwise each successive insertion detaches `toggle` from the previous position. Fixes rust-lang#17125.
|
Would you be able to host a build of the docs with the change so we can verify that everything is working as intended again? |
|
Also: thanks for fixing this! |
|
Well, I found a bug, but I'm almost certain this has always been there since I first implemented this feature. If you collapse-all on this page, all the module descriptions disappear. Beyond that, this looks great. Everything seems to be working fine again. 👍 Would hack bors to r+ |
bors
added a commit
that referenced
this pull request
Sep 17, 2014
This needs a clone otherwise each successive insertion detaches `toggle` from the previous position. Fixes #17125.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs a clone otherwise each successive insertion detaches
togglefrom the previous position.
Fixes #17125.