micro-optimize dynamic allocation alignment #17095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -149,12 +149,24 @@ unsafe fn closure_exchange_malloc(drop_glue: fn(*mut u8), size: uint, | |||
| alloc as *mut u8 | |||
| } | |||
|
|
|||
| // The minimum alignment guaranteed by the architecture. This value is used to | |||
There was a problem hiding this comment.
"guaranteed by jemalloc on this architecture", or is it actually part of the architecture's ABI?
There was a problem hiding this comment.
It's part of the ABI and therefore jemalloc and other allocators have to provide it as the minimum. Since jemalloc has to be compatible with system allocators, I just took the numbers from there.
There was a problem hiding this comment.
Okay, cool. I was just wondering if this was an additional guarantee provided by jemalloc or not.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Add CONTRIBUTING.md I'm not great with these kinds of documents, but the main point I want to be able to raise is that feature implementations should have an issue raised first for discussion.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
Add CONTRIBUTING.md I'm not great with these kinds of documents, but the main point I want to be able to raise is that feature implementations should have an issue raised first for discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some parts of this optimization were impossible because the
alignment passed to the free function was not correct. That was fully
fixed by #17012.
Closes #17092