test: Fix the tcp-accept-stress test #16894
Merged
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously asserted that each thread received at least one connection, but this is not guaranteed to always be the case due to scheduling. This test also deadlocked on failure due to a lingering reference to the sending half of the channel, so that reference is now also eagerly dropped so the test can fail properly if something bad happens. Closes rust-lang#16872
bors
added a commit
that referenced
this pull request
Aug 31, 2014
It was previously asserted that each thread received at least one connection, but this is not guaranteed to always be the case due to scheduling. This test also deadlocked on failure due to a lingering reference to the sending half of the channel, so that reference is now also eagerly dropped so the test can fail properly if something bad happens. Closes #16872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously asserted that each thread received at least one connection,
but this is not guaranteed to always be the case due to scheduling. This test
also deadlocked on failure due to a lingering reference to the sending half of
the channel, so that reference is now also eagerly dropped so the test can fail
properly if something bad happens.
Closes #16872