Improve the diagnostics for mistakes in for loops #16762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
changed the title
This improves the error message by telling the user the exact type of
`x` if it doesn't implement `Iterator` in `for ... in x {}`.
Closes rust-lang#16043.
This squashes the > `for` loop expression has type `[type error]` which does not implement > the `Iterator` trait message that one received when writing `for ... in x` where was previously found to have a type error. Fixes rust-lang#16042.
bors
added a commit
that referenced
this pull request
Aug 29, 2014
- print the type of `x` in `for ... in x` in the "does not implement Iterator" message - avoid printing that message if `x` has a type error
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 17, 2024
Added QuickFix for unresolved field. Adds an AssistKind::QuickFix for unresolved field. Currently, Snippets are not available for Diagnostics. So the type defaults to the Unit type if the type is not able to be inferred. https://github.com/rust-lang/rust-analyzer/assets/11785959/bd4c67bd-f8cb-4254-9a87-641ae80a7a28 Closes rust-lang/rust-analyzer#4563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xinfor ... in xin the "does not implement Iterator" messagexhas a type error