syntax: Fix complexity of string parsing. Closes #16624. #16659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem here was that every char iteration was formatting an error message preemptively. |
|
I think this also plagues binary literals, could a test be added for that as well? |
|
Done. I also reduced the number of characters in each test from 1,000,000 to 400,000. |
bors
added a commit
that referenced
this pull request
Aug 22, 2014
Note that this contains a 9.5MB test file, but it should compress thoroughly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this contains a 9.5MB test file, but it should compress thoroughly.